Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: select box overflow on download pages #7119

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

canerakdas
Copy link
Member

Description

While checking the Turkish translation, I noticed that the content of the selects on the download page was overflowing with text, this PR aims to solve this overflow problem

Since the platform select element is at the end of the content in most of the languages, overflow was not seen as a problem before

Here is the screenshot;
image

Validation

There should be no overflow when Chocolatey is selected in the Traditional Chinese language in the preview

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@canerakdas canerakdas added the bug label Oct 11, 2024
@canerakdas canerakdas requested a review from a team as a code owner October 11, 2024 20:44
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 11, 2024 8:46pm

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 12, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 83 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.277s ⏱️

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd added this pull request to the merge queue Oct 12, 2024
Merged via the queue into nodejs:main with commit 3da97a1 Oct 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants